[mnet-devel] Re: [mnet-cvs]this 1-line patch should fix the "we dont hello quickly en...

[Arno Waschk]

this won't do it. It still seems to set that timestamp without knowing 
that the MT was reachable. The failure is usually a timeout, not one of 
the cases checked in that function above the newly inserted line.
I am afraid one has to put that into hello response handling....
I am testing other patches in the moment, which produce nice results, 
although maybe more traffic than necessary.
Given i can have hack time tonight, i will do something about that...

On Thu, 11 Mar 2004 06:45:03 -0800, Zooko O'Whielacronx 
<zooko at users.sourceforge.net> wrote:

> Update of /cvsroot/mnet/mnet/common
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8560/common
>
> Modified Files:
> 	BrokerVersion.py MojoTransaction.py
> Log Message:
>  * this 1-line patch should fix the "we dont hello quickly enough" bug 
> -- this patch is barely tested; vernum bump -> Mnet v0.6.3.372-UNSTABLE
>
> Index: BrokerVersion.py
> ===================================================================
> RCS file: /cvsroot/mnet/mnet/common/BrokerVersion.py,v
> retrieving revision 1.444
> retrieving revision 1.445
> diff -u -d -r1.444 -r1.445
> --- BrokerVersion.py	11 Mar 2004 12:06:10 -0000	1.444
> +++ BrokerVersion.py	11 Mar 2004 14:45:00 -0000	1.445
> @@ -24,7 +24,7 @@
>  major = 0 # this will go to `1' when it is ready for widespread public 
> use !?
>  minor = 6 # release number
>  micro = 3 # bugfix release number
> -nano = 371 # everytime a developer changes anything that anyone might 
> care about, he bumps this one
> +nano = 372 # everytime a developer changes anything that anyone might 
> care about, he bumps this one
>  flag = "UNSTABLE"
>
>  versiontup = (major, minor, micro, nano,)
>
> Index: MojoTransaction.py
> ===================================================================
> RCS file: /cvsroot/mnet/mnet/common/MojoTransaction.py,v
> retrieving revision 1.78
> retrieving revision 1.79
> diff -u -d -r1.78 -r1.79
> --- MojoTransaction.py	7 Mar 2004 16:34:45 -0000	1.78
> +++ MojoTransaction.py	11 Mar 2004 14:45:00 -0000	1.79
> @@ -478,8 +478,6 @@
>          if (self._lasthellotime > self._contactinfochangedtime) and 
> (timesincelasthello < MIN_REDUNDANT_HELLO_DELAY):
>              return # never send the same contact info to MTs more often 
> than this
>
> -        self._lasthellotime = now
> -
>          debugprint("Our actual hello body is: %s\n", 
> args=(hello_body,), v=3, vs="commstrats")
>          if not hello_body.has_key('connection strategies'):
>              # Hm.  We haven't figured out how people can talk to us 
> yet.  Might as well not bother announcing then.
> @@ -491,6 +489,8 @@
>              debugprint("%s.__announce_self_to_meta_trackers(); I do not 
> know any MTs!  This is very bad.\n", args=(self,))
>              return
>
> +        self._lasthellotime = now
> +
>          fingers = idlib.chordish_fingers(self.get_id(), mts.keys())
>          hmtIds = fingers[:]
>          if len(hmtIds) < mojoutil.logish(len(mts)):
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
> _______________________________________________
> mnet-cvs mailing list
> mnet-cvs at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mnet-cvs
>



-- 
http://www.arnowaschk.de


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
mnet-devel mailing list
mnet-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mnet-devel